Daniel Dyla
Daniel Dyla
After looking into this a little more it seems there are many ways to handle this. Just looking at the https://github.com/umdjs/umd/tree/master/templates repository shows many possible "official" ways of handling this....
> Have you verified that we can implement these APIs with the existing context managers (AsyncHooks, zone.js)? If not this would be quite problematic. Yes I have implemented prototypes in...
I think not calling `detach` after calling `attach` should be considered a bug. You can't expect your context that you `attach`'d to survive the end of a `with`. You gave...
> @open-telemetry/javascript-maintainers How can we progress this PR? Looks useful The issue is that a lot of the places where this PR looks useful it is actually not. It may...
> > But I suppose that AsyncLocalStorageContextManager already utilized experimental APIs like AsyncLocalStorageContextManager.disable [[1]](https://github.com/open-telemetry/opentelemetry-js/blob/main/packages/opentelemetry-context-async-hooks/src/AsyncLocalStorageContextManager.ts?rgh-link-date=2022-06-27T02%3A31%3A19Z#L48) so it can be acceptable? > > I mean we started using ALC when it was...
Added experimental tags to the docs and verified the rendered docs look as expected. If the other maintainers don't think this is a strong enough signal to end-users, we can...
@open-telemetry/javascript-maintainers what do you think of the proposal here: https://github.com/open-telemetry/opentelemetry-js-api/pull/123#discussion_r915988746 Use would look like this: ```javascript const restore = context.attach(newContext); // do some stuff restore(); // detach context ```
~~One open question: is this considered a breaking change?~~ @open-telemetry/javascript-maintainers On further thought, it is for sure breaking if we return a suppressed instr context. If the user is manually...
Another reasonable option might be to instead of Noop context manager use an extremely simple sync context manager.
@Flarna there is no chance for the user to pass a context to be used for an export. We could create a `ManualSpanProcessor` for this usecase to be used by...