Adversarial_Video_Generation icon indicating copy to clipboard operation
Adversarial_Video_Generation copied to clipboard

GLARING bug with the process data pipeline.

Open MadcowD opened this issue 5 years ago • 0 comments

Hey all! There is a glaring bug with the data_proccess pipeline.

Currently, for each clip, the video generator sorts the data by filename ep_frame_paths = (glob(os.path.join(ep_dir, '*'))). If your files are written as

filename1
filename2
...
filenameN

and N > 10 this will interlace earlier frames of the data into the clips used for training. With a large history window this adds some robustness to the model, but it really invalidates the modeling assumption!

Sortiing by the last integer fixes this (change line 80 to this)

ep_frame_paths = sorted(glob(os.path.join(ep_dir, '*')), key=lambda x: int(x.split("frame")[-1].split(".png")[0]))

MadcowD avatar Oct 20 '19 17:10 MadcowD