pytorch_dkvmn icon indicating copy to clipboard operation
pytorch_dkvmn copied to clipboard

promble about the index of skill_id

Open xiaoLu97 opened this issue 4 years ago • 0 comments

your process of data can get 123 skills, but you set the parser.n_question 124. something stranger is followed: in data_loader.py #120, q = all_skills.index(int(attempt[0])) + 1,so q range 1 to 123. len(all_skills) ==123 in data_loader.py #121, qa = q + num_skills * int(attempt[1]), where num_skill equal len(all_skills) + 1=124 , which is default#145. So, qa can range 1 to 123 or range 125 to 247.

in model.py #37 self.q_embed = nn.Embedding(self.n_question + 1, self.q_embed_dim, padding_idx=0) self.qa_embed = nn.Embedding(2 * self.n_question + 1, self.qa_embed_dim, padding_idx=0)

what is your original idea.

i would be grateful if your reply as soon as possible

xiaoLu97 avatar Dec 09 '20 14:12 xiaoLu97