Daniel Caspi

Results 86 comments of Daniel Caspi

Btw, one potential "fix" for the capitalized names is this: ```php if ( $input === strtoupper( $input ) ) { $input = ucwords( strtolower( $input ) ); } ```

good call @luads! ```php $parser->setMaxCombinedInitials(1); ``` achieves the same result as: ```php if ( $input === strtoupper( $input ) ) { $input = ucwords( strtolower( $input ) ); } ```...

Ah, thanks @NorthernMan54 ... so the merging of all accessories into a single list is intentional? Just wasn't clear why there would be 2 PIN# dropdowns when choosing `hb-control`, etc....

@NorthernMan54 updated both branches here with a modified variant for this.

Thanks @NorthernMan54! Glad to finally find a more amenable solution that doesn't break other plugins that use it. Yes I noticed the same thing about the red triangle. I don't...

Interesting. If that's true, why in Hap-Node-Client, do you have functions like this: ``` HAPNodeJSClient.prototype.HAPstatus = function(ipAddress, port, body, callback) { ``` ``` HAPNodeJSClient.prototype.HAPevent = function(ipAddress, port, body, callback) {...

I see. I think I know what the issue is now: ```js HAPNodeJSClient.prototype.HAPresourceByDeviceID = function(deviceID, body, callback) { // console.log('This-0', this); _mdnsLookup(deviceID, function(err, instance) { // console.log('This-1', this); if (err)...

> I did an audit of your change, and it looks like you covered all the external interfaces. Thanks for checking. Yes, tried to make it robust because I wasn't...

See what you think of this @NorthernMan54 : https://github.com/NorthernMan54/Hap-Node-Client/pull/49

> During regression testing I did find an issue where all use cases where failing with "Homebridge not initialized". Did a bit of digging into it and found this was...