halstack-react icon indicating copy to clipboard operation
halstack-react copied to clipboard

DxcTextInput - have option for Prefix where it has divider ( | ) sign which is confusing, Couldn't find any option to remove the same

Open mjayaraj2 opened this issue 2 years ago • 5 comments

Is your feature request related to a problem? Please describe. In DxcTextInput component, we have option for Prefix where it has divider ( | ) sign which is confusing, Couldn't find any option to remove the same. In US, they always use like this $ 10,000.00 . Need provision to remove the divider

Describe the solution you'd like There should be provision to remove the divider ( | ) sign

Describe alternatives you've considered Customizing the DxcTextInput which is not the preferrable

Additional context There should be provision to remove the divider ( | ) sign

Add Labels Add any applicable labels like related components, services, team or project reporting this new feature... etc.

DxcTextInputWithDivider

mjayaraj2 avatar Nov 29 '23 12:11 mjayaraj2

Hi @mjayaraj2 , Thanks for reaching out.

Having a divider is a design decision that Halstack Designers can probably justify with arguments like accessibility or readability. I will let them to comment

kukoc avatar Nov 29 '23 15:11 kukoc

Hello @mjayaraj2,

As Aitor mentioned before, the decision to include a divider in our Text Input, in this case, responds to design needs in terms of usability. The presence of a divider that separates the prefix/suffix from the actual value helps the user to differentiate the format (whether they are item numbers or currencies) and creates a hierarchy between the prefix and the value to be entered.

Moreover, in this use case, the presence of the divider does not alter the intended result. In both cases (with or without divider) it is understood that the value entered is $ 10,000.00.

Thanks for reaching out!

lcordobapuerto avatar Nov 29 '23 15:11 lcordobapuerto

More feedback from Janice:

From a business perspective, the divider bar is very distracting on an entry field. Since we are a financial system, amount entry fields are prevalent in our views. As a user, the divider is confusing and distracts from the dollar prefix.

We would really appreciate it if you would reopen this and provide an ability to show/hide any dividers.

Thanks!

kukoc avatar Nov 29 '23 16:11 kukoc

Hi there! As we've stated before, the presence of a divider in the prefix/suffix in our Text input is supported by a design decision to improve the overall user experience and usability of said component. However, we understand that using a divider in a prefix/suffix of a currency is a special use case, which is why we're collecting all your valuable inputs to evaluate the possible future addition of an Amount component to Halstack. In addition, we're always glad to receive contributions, so if you have something in mind, we'll be happy to consider your inputs for this possible new component. Thank you!

lcordobapuerto avatar Dec 01 '23 12:12 lcordobapuerto

As there has been no further activity, this issue is closed.

GomezIvann avatar Feb 01 '24 15:02 GomezIvann

Hey there! We have been thinking about this issue for a while now, do you think this approach could work for you? Can you please check with your team that this is what you are looking for? NI - no divider Thank you!

lcordobapuerto avatar May 20 '24 06:05 lcordobapuerto

This issue is stale because it has been open for 15 days with no activity. If there are no further updates or modifications within the next 15 days, it will be automatically closed.

github-actions[bot] avatar Jun 05 '24 01:06 github-actions[bot]

@mjayaraj2 , please share your feedback. Thanks

kukoc avatar Jun 06 '24 11:06 kukoc

Yes, would prefer to see as below DxcTextInputDollarsign

mjayaraj2 avatar Jun 06 '24 15:06 mjayaraj2

Yes, would prefer to see as below DxcTextInputDollarsign

Hello again,

This image does not correspond to our designers' proposal, but we will do our best to meet your needs. I will work on it.

Thanks!

GomezIvann avatar Jun 06 '24 15:06 GomezIvann