Groups
Create groups: many_to_many groups - lists many_to_many groups - people
Codecov Report
Merging #169 (3827047) into main (7d05242) will decrease coverage by
17.52%. The diff coverage is50.00%.
@@ Coverage Diff @@
## main #169 +/- ##
============================================
- Coverage 100.00% 82.47% -17.53%
============================================
Files 13 23 +10
Lines 219 331 +112
============================================
+ Hits 219 273 +54
- Misses 0 58 +58
| Impacted Files | Coverage Δ | |
|---|---|---|
| lib/app/group_list.ex | 0.00% <0.00%> (ø) |
|
| lib/app/group_person.ex | 0.00% <0.00%> (ø) |
|
| lib/app_web/controllers/group_controller.ex | 0.00% <0.00%> (ø) |
|
| lib/app_web/controllers/group_list_controller.ex | 0.00% <0.00%> (ø) |
|
| lib/app_web/controllers/group_member_controller.ex | 0.00% <0.00%> (ø) |
|
| lib/app/group.ex | 20.00% <20.00%> (ø) |
|
| lib/app/person.ex | 77.77% <50.00%> (-22.23%) |
:arrow_down: |
| lib/app/item.ex | 100.00% <100.00%> (ø) |
|
| lib/app/list.ex | 100.00% <100.00%> (ø) |
|
| lib/app/list_item.ex | 100.00% <100.00%> (ø) |
|
| ... and 4 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
@SimonLab in light of my comment in https://github.com/dwyl/auth/issues/220#issuecomment-1273033055 I made the case that groups belong in the auth application where all personally identifiable info is stored.
I think it makes sense to add groups to the MVP for speed.
But ultimately we should not be duplicating the people table in two places.
Personally identifiable data should exclusively be stored in the Auth App which will be deployed on separate infrastructure.
For the purposes of adding collaboration to the MVP we can add people and groups here,
but this is not where this data will be stored longer term because we don't want to mix the concerns.