Check ci before awaiting review label added

[naazy]

check failing test before adding awaiting-review label #126

[dwylbot[bot]]

@naazy, hoorah! 🎉 It's review time! 👀

I couldn't help but notice that there isn't an in-progress label on this pull request and a Reviewer has been added...makes me think that this pull request is ready for review 🤔

To save you time ⏳ I've added the Reviewer as an Assignee and I've added the awaiting-review label - automatically - just like magic! 🎩 🐰 ✨. Please correct me if I'm wrong, but if I got it right this time I hope it helps you! 😄

Any questions, complaints, feedback, contributions? If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new

[dwylbot[bot]]

:warning: @naazy, the pull request is in "awaiting-review" but some tests are failing. Please fix the tests and reassign when ready :+1: Thanks

Any questions, complaints, feedback, contributions? If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new

[naazy]

Reason for failing test:

[naazy]

@shouston3 Any help figuring out why this is failing CI would be great! I think it's something to do with my tables not being set up correctly on travis because this PR introduces dwylbot's first postgres queries. :pray: 📿 please/thanks

[samhstn]

@naazy I'll have a look

[samhstn]

@naazy I'm not sure what you were trying to do here. Was this working locally for you?

The replaced code inserts into the commits table (fixing the test). Is this the desired functionality?

Also, you should try to insert the model changesets over inserting the structs directly

[codecov[bot]]

Codecov Report

Merging #150 into master will decrease coverage by 0.37%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
- Coverage   98.32%   97.94%   -0.38%     
==========================================
  Files          23       24       +1     
  Lines         179      195      +16     
==========================================
+ Hits          176      191      +15     
- Misses          3        4       +1

Impacted Files	Coverage Δ
web/controllers/rules/pr/awaiting_review.ex	100% <100%> (ø)	:arrow_up:
web/controllers/rules/status/travis_failure.ex	100% <100%> (ø)	:arrow_up:
web/models/commits.ex	100% <100%> (ø)
web/models/user.ex	50% <0%> (-50%)	:arrow_down:
web/controllers/rules/issue/time_estimation.ex	100% <0%> (ø)	:arrow_up:
web/controllers/rules/pr/merge_conflict.ex	100% <0%> (ø)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4d1b10f...4087a7c. Read the comment docs.

[naazy]

@shouston3 Thanks for your help resolving the test! Yes it worked locally but your way is a lot clearer and the tests like it a lot more :smile:

[dwylbot[bot]]

@naazy, hoorah! 🎉 It's review time! 👀

I couldn't help but notice that there isn't an in-progress label on this pull request and a Reviewer has been added...makes me think that this pull request is ready for review 🤔

To save you time ⏳ I've added the Reviewer as an Assignee and I've added the awaiting-review label - automatically - just like magic! 🎩 🐰 ✨. Please correct me if I'm wrong, but if I got it right this time I hope it helps you! 😄

Any questions, complaints, feedback, contributions? If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new

[naazy]

On second thoughts. the query change by @shouston3 is not quite what we want because it's an an insert but we need an upsert https://hexdocs.pm/ecto/Ecto.Repo.html#c:insert/2-upserts with my query. It turns out I just had to update my postgres version in travis.yml