dwyl-site icon indicating copy to clipboard operation
dwyl-site copied to clipboard

Sonarwhal Website Lint Report for dwyl.com

Open nelsonic opened this issue 6 years ago • 6 comments

https://sonarwhal.com is an Open Source website scanning tool that checks for asite's accessibility, speed and common errors. see: https://github.com/sonarwhal/sonarwhal

image

The Scan for the dwyl.com website: https://sonarwhal.com/scanner/17e38af9-0bb0-43f0-8d42-986c00151158 image

Reveals quite a few (86) errors ... 😞 @iteles what are your thoughts on addressing these?

nelsonic avatar Apr 12 '18 20:04 nelsonic

That's interesting. We have used other tools in the past that have apparently been more 'forgiving':

See https://github.com/dwyl/dwyl-site/issues/14#issuecomment-334194425 and http://wave.webaim.org/report#/dwyl.com screen shot 2018-04-12 at 22 27 47

Also, not being able to have links inside <li>s? I've never even heard of that as a thing.

iteles avatar Apr 12 '18 21:04 iteles

@iteles yeah, I was not aware of the no <a> in <li> "rule" either ... 🙄 I like the fact that Sonarwhal can be run on Continuous Integration (Travis-CI) 🔴 / ✅ ? such that any update to the site will automatically be "rejected" if it fails to pass. ⛔️ Also, this goes way beyond Accessibility ... 🔓 And it's Open Source so we can inspect the code 🔍 if/when we need to understand the reason why something is failing ... 😉

nelsonic avatar Apr 13 '18 09:04 nelsonic

Agreed! I had suggested we set up a pa11y pre-commit hook as a starter here: https://github.com/dwyl/dwyl-site/issues/409#issuecomment-334158068

As you say, this goes much further. I'd like to make sure there is research/tests to back up that particular 'rule' first though!

iteles avatar Apr 13 '18 15:04 iteles

So I was lucky enough to see this one during the conference https://www.youtube.com/watch?v=O_OJfY4Jax4&feature=youtu.be

But we should share this video with everyone.

I don't think it's related to this issue in particular.

sohilpandya avatar Apr 13 '18 16:04 sohilpandya

Oh I'm so glad there's a video of it @sohilpandya, thanks for sharing, the tweets from that session were FANTASTIC!

iteles avatar Apr 13 '18 16:04 iteles

https://sonarwhal.com/ image

Rebranded as https://webhint.io/ image

Still super on-board with this. https://github.com/webhintio/hint Definitely going to need something like this for the new site: https://github.com/dwyl/dwyl-site/issues/493

nelsonic avatar Oct 11 '22 14:10 nelsonic