dwyl-site icon indicating copy to clipboard operation
dwyl-site copied to clipboard

Published 20 hours ago • verified publisher icon dwyl

Why is 'blog' always highlighted?

Open iteles opened this issue 7 years ago • 3 comments

Why is 'blog' in the nav always turquoise, no matter what page I'm on?

I keep thinking it's highlighting the page I'm looking at.

I would also suggest that until we actually have some content, we probably don't want to highlight the Blog link.

screen shot 2017-10-09 at 19 26 29

iteles avatar Oct 09 '17 18:10 iteles

@iteles Just to differentiate it from the other types of links on the navbar. If it's confusing it should go.

harrygfox avatar Oct 13 '17 14:10 harrygfox

Thanks for clarifying @harrygfox! Only confusing because we don't really have one yet! Let's change it now and change it back when we want to differentiate it :+1:

iteles avatar Oct 13 '17 16:10 iteles

half-solved this with my PR which removes the blog link highlighting...

Proposal to fix: create function to get the pathname with JS and match it to the correct menu link, then add class to highlight it

would this go in script.js?

or it's own menu-highlighter.js?

Rob-Rychs avatar Dec 04 '17 18:12 Rob-Rychs