contributing icon indicating copy to clipboard operation
contributing copied to clipboard

Published 20 hours ago • verified publisher icon dwyl

Opening a PR, removing 'in-progress' label: Remove self-assignment from issue too?

Open mk4111 opened this issue 8 years ago • 4 comments

When we work on an issue, the first thing we do (upon getting the green light to actually work on the issue), is a) assigning oneself to the task/issue and b) sticking the 'in-progress' label on.

When we are done working on the issue, and have made a PR, we assign the PR to another person to review, and we also remove the 'in-progress' label from the issue, but do we also remove ourselves from 'Assignees'?

mk4111 avatar Feb 15 '17 21:02 mk4111

@mk4111 yes I believe so, then if the PR requires changes the reviewer assigns you back on - @nelsonic and I are going over the contributing guide tomorrow afternoon to help make it easier to read and understand

ghost avatar Feb 15 '17 21:02 ghost

@markwilliamfirth - cool! Thank you! I'll close this issue once I've had a read of the update!! Hope that's ok! :)

mk4111 avatar Feb 17 '17 11:02 mk4111

Hi @markwilliamfirth! Forgive me if I'm being a bit of a Humpty Dumpty and it's already been updated, but can you let me know if/when the README gets updated so I can be sure to check it out and close this issue? Thank you!

mk4111 avatar Mar 08 '17 12:03 mk4111

It hasn't been updated yet - it got pushed back :( I'll update here when it is

ghost avatar Mar 08 '17 14:03 ghost