adoro icon indicating copy to clipboard operation
adoro copied to clipboard

Published 20 hours ago • verified publisher icon dwyl

BLCRS Timeout in tests.js

Open thegsi opened this issue 9 years ago • 0 comments

Not sure why the timeout approach has been adopted.

  1. Could the equals go inside the fs functions' callbacks.
  2. Could you use the sync versions of the fs functions?
  3. If the seTimeout is required perhaps a comment could be useful to explain.

https://github.com/dwyl/adoro/blob/BLCRS/test/tests.js#L38 https://github.com/dwyl/adoro/blob/BLCRS/test/tests.js#L58

thegsi avatar Dec 04 '15 11:12 thegsi