David Sutherland
David Sutherland
> > Although, I haven't been about to setup permissions properly for my other-user . > > What do you mean by "privileges" - just fine grained authorization of Cylc...
> Is it this: #692 Fixed: https://github.com/cylc/cylc-uiserver/pull/693
> Couple of changes accidentally reverted in latest force push (I've unresolved the conversations) Yeah, I probably didn't fetch these locally
Will fix any in the morning (if that's ok).. looks like mypy is failing at min (although if it's a simple fix, welcome to push)
Tests are passing, however, coverage is a bit rubbish with the new code, so I've replaced the ignored `cylc/uiserver/websockets/*` with `cylc/uiserver/graphql/*` (although, it's not all foreign (~half) so it should...
Coverage of untested code reinstated.. Will raise a new PR next week for this
Tests appear to be failing because of the new change in master? ``` File "/home/runner/work/cylc-uiserver/cylc-uiserver/cylc/uiserver/__init__.py", line 20, in from cylc.uiserver.app import CylcUIServer File "/home/runner/work/cylc-uiserver/cylc-uiserver/cylc/uiserver/app.py", line 90, in from cylc.flow.network.graphql import...
> The message sounds like it is complaining about the use of a list as a default value, however, we do the exact same thing with broadcasts just a couple...
I've been trying to get the subscription test working, so far I have got to using: ``` @pytest.fixture def gql_sub(jp_ws_fetch): """Perform a GraphQL request. E.G: conn = await gql_sub( *('cylc',...
> If this is a new test, maybe remove it from this PR and prepare a new PR to add the tests? Yes, will do.