David Steele
David Steele
Yeah, looks like coverage is next. The main test cert will need to be rebuilt, see `test/certificate/README.md`. Then we'll need some new tests right around line 610 in `ioTlsTest.c`.
This seems like it would be a good enhancement but not sure when we would be able to do it. If you are able to write the patch that would...
The OP is not working on it and it is not a priority for us, either.
@andr-sokolov It looks like https://github.com/arenadata/pgbackrest/commit/ed3c519b5d389e47c1c553e5e597ecacac4e3383 fixes this issue. Could you submit a PR for it?
Closing since there is a PR now to fix this.
This looks like it would lead to incorrect audit results. Have you tried running the tests with this change?
The purpose of that NULL check is to save some info for later when we *will* have some info on the stack to call log_select_dml(). Doing everything through callbacks is...
Have you looked at https://github.com/fmbiete/pgauditlogtofile/issues/32 (found with a cursory search)?
Sorry -- I've never seen the error before so no ideas on how to reproduce.
Looks like Postgres is telling pgAudit that this entire statement is a grant so we don't even try to do any redaction. I'm not sure if there is anything we...