David Steele

Results 421 comments of David Steele
trafficstars

> Do you have a revised timeline for the release? Well, I meant to say *August 25* above. But in any case we have moved it to August 31 so...

I'm not seeing anything obvious that would cause this. Dropping files from the queue is pretty early on an I can't see any S3 accesses before this. Can we see...

> I can provide the full log with DEBUG Just debug will be fine. Try compressing it and attaching to this issue and see if that works.

One thing to note, if `archive-push-queue-max` is exactly the size of the storage allocated to WAL (or even close), then it may not work as expected. We only check the...

When exactly did the WAL volume fill up on the primary? I can see the errors starting here: ``` 2022-08-22 11:53:39.055 P03 WARN: could not push WAL file '000000030000AF9800000094' to...

Limiting the batch size would be pretty easy, I think, but I'm worried that lots of retries could still present a problem even for smaller batch sizes since each one...

> Another thought though is to perhaps review the queue size after the first error as we have some idea that it probably took a while for the error to...

Yeah, looks some frees got missed when converting `restoreFile()` to use loops in the file bundling commit. PR #1878 implements a fix. Please give that a try if you are...

> Thank you for the quick fix It was pretty obvious once I knew it was there. The update should also help prevent future leaks. Of course, this just missed...