zxcvbn-python icon indicating copy to clipboard operation
zxcvbn-python copied to clipboard

Version 4.5.0 was not published correctly to PyPI

Open AbsurdlySuspicious opened this issue 7 months ago • 2 comments

Source tarball on pypi [1] has version 4.5.0 specified in setup.py, but contains no changes related to frequency lists initialization and still contains add_frequency_lists helper function which should have been removed in 4.5.0 according to tagged version on github. Maybe there's more stuff missing, I didn't check everything

[1] https://pypi.org/project/zxcvbn/4.5.0/#files


add_frequency_lists helper function

I'm also not sure if this removal was intentional. It would be good to reimplement it again if it wasn't.

AbsurdlySuspicious avatar Jun 12 '25 02:06 AbsurdlySuspicious

It would be good to reimplement it again if it wasn't.

See #86

AbsurdlySuspicious avatar Jun 12 '25 17:06 AbsurdlySuspicious

Maybe there's more stuff missing, I didn't check everything

I came across this issue and wanted to check what's up before updating.

The wheel on PyPI is missing these two commits:

  • f4161482786f69c79acbe982dec6bcba84c9119d decorator solution for lazy loading frequency_lists library
  • 2939b6bbbbd5e8b37b3fa02826cabd1d929df4bf handle zero-length password gracefully

(I.e. after checking out tag v4.5.0 and reverting these commits, the wheel you build locally matches what's on PyPI)

RazerM avatar Jul 04 '25 08:07 RazerM