donw.io icon indicating copy to clipboard operation
donw.io copied to clipboard

Comments: Replacing Disqus with Github Comments

Open dwilliamson opened this issue 7 years ago • 226 comments

This is a comment

dwilliamson avatar Apr 18 '17 22:04 dwilliamson

This is another comment

dwilliamson avatar Apr 18 '17 23:04 dwilliamson

This is a comment with some markdown...

  • Listy
  • Listo
  1. Jumble
  2. Sale

Boldit or Italicit or ~strikeit~

header

hashtag

something something

int x = 3;

dwilliamson avatar Apr 18 '17 23:04 dwilliamson

This is great. Thanks for sharing this!

jasminpatry avatar Apr 21 '17 23:04 jasminpatry

Awesome ! I think I will try this on my website. :)

olafleur avatar Apr 22 '17 01:04 olafleur

Nicely done.

vielmetti avatar Apr 22 '17 01:04 vielmetti

Neat!

vyp avatar Apr 22 '17 01:04 vyp

You are on HN, congrats :) https://news.ycombinator.com/item?id=14170041

olalonde avatar Apr 22 '17 01:04 olalonde

I agree that what Disqus is doing is an overkill. However, we should not forget that nothing comes for free... Apart from this, getting redirected to GitHub for comment is very inconvenient... Update: So I am automatically subscribed to comments thread via email... Getting emails not only for replies on my comment but for every new comment. Well, this is another overkill... Don't forget User experience is more valued than user's data nowadays :D

Edit: @dwilliamson forget about the free-ness argument, the bigger issue is of user experience, I got resubscribed to email updates after you mentioned me in one of the comment. This is a serious poor user experience.

mannuscript avatar Apr 22 '17 01:04 mannuscript

Interesting, thanks for sharing!

You might consider changing the link to include #new_comment_field (like so) so that users do not have to scroll. I believe this also focuses the field by default, which may make intent more clear.

Adding a button at the bottom of the comments section that opens the link might be helpful. Using about: _blank could be nice too.

A git hook might be useful to automatically generate the issues, though I'm not sure that'd be a good idea.

EDIT: Looks like their api supports POSTing comments; you'd have to set up user auth of course. https://developer.github.com/v3/issues/comments/#create-a-comment

rattrayalex avatar Apr 22 '17 02:04 rattrayalex

A test of comment with image and link.

img_4698

ghost avatar Apr 22 '17 02:04 ghost

Good work. In summary, to improve the solution further, add a button to add a new comment. Only when that button is pushed (in order to preserve privacy, remove drive-by viewer tracking potential, and reduce unnecessary server load on Github), somehow determine whether the user is already logged in to Github.

  • If not, then give them a chance to do so or sign up
  • If so, then display an add comment form on the page This could be a modal window, in a similar style to Stripe. If the user posts a comment successfully, the comment stream could be refreshed.

globalcitizen avatar Apr 22 '17 02:04 globalcitizen

I'm impressed by this! I'm going to see what happens when you post a comment from the @ghost account (another name for a deleted account)

citrusui avatar Apr 22 '17 02:04 citrusui

Hello world! This is a comment from the @ghost account.

ghost avatar Apr 22 '17 02:04 ghost

This is awesome!

segiddins avatar Apr 22 '17 02:04 segiddins

You might want to

  1. Add rel="nofollow" to your anchor tags to deter spam

  2. Link back to the blog post in the GH issue (you could do that in the first comment and not display it on your website). That way when I go back here due to :octocat: GH notifications, I can go back to the post easily instead of wondering what this is all about 😸

olalonde avatar Apr 22 '17 03:04 olalonde

Great writeup, I was really hoping there was a way to comment without visiting Github.

ElijahLynn avatar Apr 22 '17 03:04 ElijahLynn

Very slick! I came to propose something similar to @globalcitizen's proposal, but they put it more succinctly.

asciimo avatar Apr 22 '17 03:04 asciimo

Did you consider https://staticman.net ? This gets you comments as PRs and comments from the page.

bexelbie avatar Apr 22 '17 03:04 bexelbie

@bexelbie but staticman isn't as FUCKING AWESOME as this

tbodt avatar Apr 22 '17 04:04 tbodt

This is amazing! Thanks for sharing.

dipakc avatar Apr 22 '17 04:04 dipakc

Great! I can already think of a few use cases for this in my team

aleman avatar Apr 22 '17 04:04 aleman

Great idea. Thank you for this.

colinmegill avatar Apr 22 '17 05:04 colinmegill

I agree this is a great idea. But why not write your post directly into the issue as well? You might want to checkout my post Turn your GitHub issues into blog posts, which implements the same idea but also let you publish right from your GitHub issue as well.

crohr avatar Apr 22 '17 05:04 crohr

Love it! :+1:

bkaradzic avatar Apr 22 '17 05:04 bkaradzic

Very useful!

lrzedzicki avatar Apr 22 '17 06:04 lrzedzicki

Great technique that I'll definitely steal. Thanks!

andreis avatar Apr 22 '17 07:04 andreis

Brilliant idea!

ghost avatar Apr 22 '17 07:04 ghost

test = {
  something: 'monkey',
  function: function(arg) { return arg + 'YAY!'  }
}

Edit: We need pagination!

EddieOne avatar Apr 22 '17 07:04 EddieOne

Great ! I'll try this out... is it doable with a gitlab instance ?

cerisara avatar Apr 22 '17 07:04 cerisara