LeafletSlider icon indicating copy to clipboard operation
LeafletSlider copied to clipboard

Memory Leak Issue

Open markworden opened this issue 9 years ago • 1 comments

Hi great job on this slider. It is very useful. I wanted to report an issue though where there is a memory leak that I believe is related to not unbinding the mousedown and mouseup events in the onRemove. I happen to be creating a removing the old slider control and creating a new slider control when my data is updated, and I saw the memory usage increasing. Using the Chrome dev tools, I found that it was related to the slider control. I made an update to the code to unbind the listeners in the onRemove, and the memory leak has gone away. If you want me to send you my version of the code, please let me know.

markworden avatar Dec 30 '15 14:12 markworden

Thanks. Could you provide your changes as a pull request?

dwilhelm89 avatar Dec 31 '15 11:12 dwilhelm89