validating
validating copied to clipboard
Validation incorrect work with accessors Issue #177
Issue #177 The attributesToArray method already returns attributes that are mutated and converts Carbon dates to strings. Plus, it adds appended accessors and applies type casting.
Thanks for this - happy to consider it, but it's concerning that the change has broken the tests. If you can show that it works without breaking the existing functionality and add additional tests as necessary I'll re-review.
I can appreciate that.
It seems to be the same problem for all the errors. Laravel's code to convert Carbon to a string checks the database if it doesn't know what format it's in. That's when it barks about the connection.
I think it could be the tests. I read the setUp function should call it's parent which would initialize the app (for things like the connection), but I see this package uses phpunit 4, so maybe that's not the case.
I can't get the tests working locally at the moment and I've tapped out my available time for the next little while. I'll look again as soon as I can.