aws-wrap icon indicating copy to clipboard operation
aws-wrap copied to clipboard

Gracefully shutting down the AmazonsS3 ExecutorService

Open bluesockets opened this issue 9 years ago • 3 comments

Hello. Here is a PR that will gracefully shuts down the S3 ExecutorService. Currently the shutdown() method issues a shutdownNow() that interrupts the com.amazonaws.http.IdleConnectionReaper causing it to throw an java.lang.InterruptedException. Issuing a shutdown() with a 30 second timeout gets rid of the exception, and allows some time for the client to spin down.

Thanks for your work on aws-wrap

bluesockets avatar Feb 03 '16 20:02 bluesockets

@dwhjames this looks good. Can someone please merge?

alexmnyc avatar Feb 08 '16 20:02 alexmnyc

Is this still actively maintained? @dwhjames

malcolmgreaves avatar Apr 06 '16 20:04 malcolmgreaves

@bluesockets I have fork and merged your PR. I have also publish it under version 0.9.0 https://github.com/mingchuno/aws-wrap

mingchuno avatar Jul 16 '16 19:07 mingchuno