David Warde-Farley

Results 154 comments of David Warde-Farley

Yes, it does. It's unclear to me why you'd want a single state object and not want to encapsulate it as one per transformer though, since you already have such...

It should be almost trivial with [SourcewiseTransformer](https://github.com/mila-udem/fuel/blob/master/fuel/transformers/__init__.py#L222) and/or [AgnosticSourcewiseTransformer](https://github.com/mila-udem/fuel/blob/master/fuel/transformers/__init__.py#L293).

It's not very future-proof to take a shape-tuple and do some prespecified operation on it without knowing what the semantics that the source Brick assigns to it are. What I'm...

I'll let someone more familiar with `recurrent` do the review but I know they will ask for you to add a test. :smile:

It'd be nice if Theano supported that case but I think it's fine to special-case our code. Feel free to submit a PR.

Initialization seems trickier since I can imagine wanting to explicitly reinitialize. Are there similar circumstances for allocation? Might be worth making those changes, one at a time, and running the...

Yes, something like that sounds like a good idea. I vaguely remember @bartvm objecting to such a keyword for `push_initialization_config`, though, so I'd be curious to hear his thoughts. I...

One thing that's annoying is that if anyone with collaborator privileges edits files through the Web in order to send a quick PR (like the child-prefix PR I sent you...

Indeed, it's kind of annoying to remember to flatten each time. I also don't totally buy the metadata argument that was the justification: that the dimension label should be "index"....