supersonic icon indicating copy to clipboard operation
supersonic copied to clipboard

Downloading music with slow connection times out after 10 seconds

Open SnipeXandrej opened this issue 11 months ago • 1 comments

When I have poor internet connection and I try to download some music, the downloading will stop after 10 seconds. When the download stops, this error/warning appears in the terminal: context deadline exceeded (Client.Timeout or context cancellation while reading body).

Perhaps this commit that introduces a 10 second connection timeout is unintentionally interrupting any download that takes more than 10 seconds? https://github.com/dweymouth/supersonic/commit/eab7842424562c87814a43a12e42964464af630a

SnipeXandrej avatar Mar 05 '24 17:03 SnipeXandrej

Yes you are right - the 10 second timeout will be problematic for downloads. However, removing it everywhere would mean the app would never give up waiting for a response from the server for other endpoints. I probably have to use a new HTTP client with no timeout just for the download API call.

dweymouth avatar Mar 06 '24 02:03 dweymouth