magmi-git icon indicating copy to clipboard operation
magmi-git copied to clipboard

Added checking is property not empty string

Open idziakjakub opened this issue 7 years ago • 3 comments

This change fixes null return when property is empty string. When property was empty default value has never been returned.

idziakjakub avatar Mar 01 '17 09:03 idziakjakub

This patch also fixed division by zero issue.

tmotyl avatar Mar 01 '17 09:03 tmotyl

@dweeves any feedback on this?

tmotyl avatar Jun 12 '17 17:06 tmotyl

hi, i was hesitating to merge because of possible impact for purposedly empty values in config files for plugins (which inherit from properties). i don't think there are many (or even if they are any in fact) , but if there are, this will break the plugin testing explicitely for empty value on one of its settings. So , maybe a better fix would be in magmi_config parsing rather than ignoring empty values in properties .

dweeves avatar Jun 13 '17 02:06 dweeves