Dave Cridland

Results 27 comments of Dave Cridland

There is a problem here that in a groupchat of (say) 50 people, to show 20 messages in the scrollback means pulling 1000 messages from MAM. This is pretty painful...

Well, our clients do not request all messages at once of course, but on high latency links, that just means lots of MAM queries, each costing 1xRTT.

To clarify, I'm not saying "Don't do this", because we do, and it's useful. But it has severe downsides and it might be worth considering making it an option at...

I was expecting the proposal to include the Release Artifacts as an option - I'd be absolutely fine with relying on an uploaded asset for the particular release. It puts...

> Oooh, another experiential one. When the JDK base image updates, it invalidates the docker cache at the first line. Wonder if we could pin stuff for the early steps,...

> Other than the one thing on Maven, this looks really good! > > First run: 534.9s Second run: 0.9s 🎉 That looks like full cache. The better test is...

Summary of those additional commits: * Merged main * Switch to our mvnw * Used eclipse-temurin:17 as the base/JDK image * Improved caching of dependencies * Used a skeleton stage...

> Assuming that this builds Openfire from source, it may be able to leverage the Maven wrapper that's part of the repository (`./mvnw`) rather than download/install one. Done!

> @dwd Do you have time to cast some stink eye over the mess I've made of your PR, and of my comments? Also done, removed the need for sudo...