dogfish icon indicating copy to clipboard operation
dogfish copied to clipboard
verified publisher icon dwb

Allows numbers and underscores.

Open defin opened this issue 10 years ago • 2 comments

Modified sed filter to allow underscores to be used instead of or in addition to dashes. Also allows numbers to be used in other parts of the name than the version id (must be separated from the version by at least one _ or -).

defin avatar Jul 21 '15 21:07 defin

This commit breaks the CI test: Testing full_mysql_migration... FAIL: Expected '0000 1234 5678 9999' to equal '1234 5678'

With the new test cases I added, '0000 1234 5678 9999' is the correct result but I'm not sure how to update the CI.

defin avatar Jul 21 '15 21:07 defin

Thanks for contributing! Have a look through dogfish_test – that just looks like the test that runs a full migration not knowing about your new migrations in the template. For example, the one that's failing is this line. Doubtless there will be more to update too... The tests should be straight-forward to run locally, let met know if you run into issues.

I'm not super keen on migration/rollback scripts not having nice names, but I guess this is meant to be a liberal tool and there's no technical reason why not.

dwb avatar Jul 21 '15 21:07 dwb