minorminer icon indicating copy to clipboard operation
minorminer copied to clipboard

Published 20 hours ago • verified publisher icon dwavesystems

cmake doesn't install anything

Open yurivict opened this issue 2 years ago • 5 comments

Description There are no install instructions in the code so there is no install target for make.

Environment:

  • OS: FreeBSD 13.1
  • Python version: 3.9

yurivict avatar Aug 14 '22 18:08 yurivict

Hi @yurivict , there are instructions for using cmake to run the tests. Otherwise this is intended to be used a header only library.

arcondello avatar Aug 26 '22 23:08 arcondello

@arcondello Header-only libraries should also be installed. Packages are created for them and then used to build other packages.

yurivict avatar Aug 26 '22 23:08 yurivict

The include folder contents should probably be installed into include/minorminer.

yurivict avatar Aug 26 '22 23:08 yurivict

Yuri,

The person who wrote the CMake files is no longer a contributor to this repo, and that's not my area of expertise. If you're able to contribute an installation recipe, I'll be willing to maintain it.

boothby avatar Aug 27 '22 15:08 boothby

Ok, I will submit a PR for this.

yurivict avatar Aug 27 '22 16:08 yurivict