dwave-system icon indicating copy to clipboard operation
dwave-system copied to clipboard

pep8 compliance in dwave.embedding.polynomialembedder

Open arcondello opened this issue 7 years ago • 3 comments

For the polynomailembeddor file https://github.com/dwavesystems/dwave-system/blob/38e5b5bae6527e812a316a829fc19f43bb380f7f/dwave/embedding/polynomialembedder.py#L47

See discussion in #111 , especially https://github.com/dwavesystems/dwave-system/pull/111#issuecomment-429480604

arcondello avatar Oct 16 '18 17:10 arcondello

The term "full yield" is not accurate here.

An "evil" coupler, in my old terminology, is an internal coupler (a coupler between a horizontal and a vertical qubit) for which both qubits exist but the coupler does not.

"No internal defects" means that "no internal couplers are missing unless one of their qubits is missing"

It's quite a far cry from "full yield" -- and using that familiar term would cause significant confusion -- it's fine for qubits to be missing, and it's also fine for external couplers (those between qubits which are parallel) to be missing where both endpoints are present.

boothby avatar Oct 16 '18 18:10 boothby

also, do you mean to be propagating the "embeddor" typo?

boothby avatar Oct 16 '18 18:10 boothby

No, I just seem to really like that spelling

arcondello avatar Oct 16 '18 20:10 arcondello