dwave-ocean-sdk icon indicating copy to clipboard operation
dwave-ocean-sdk copied to clipboard

Published 20 hours ago • verified publisher icon dwavesystems

Add dwave-samplers 1.0.0.dev0

Open arcondello opened this issue 2 years ago • 3 comments

arcondello avatar Jul 29 '22 20:07 arcondello

Current test failures seem to be from an interaction between https://github.com/dwavesystems/dwave-neal/pull/91 and dwave-hybrid. Can look into it next week.

arcondello avatar Jul 29 '22 22:07 arcondello

@arcondello, Test failures stem from a backward-compatibility breaking change in dwave-neal#91 -- num_sweeps now has to be positive.

And in dwave-hybrid (tests) we set num_sweeps=0 to verify initial state is correctly propagated through the SA runnable.

We can rework that test, but IMO, it's nice to have a "NOP" SA/sampler input. OTOH, supporting that in the current Neal code does not seem straightforward.

randomir avatar Aug 02 '22 16:08 randomir

Looks good, it's just not clear to me why are we adding docs manually here, instead of using Neal's docs (with deprecation note added there)?

We talked about this offline, but for posterity it could be done either way. I slightly prefer this one because then we use the version number of the sdk in the deprecation warning. Also makes the existing dwave-neal repo a bit smaller/tidier.

arcondello avatar Aug 12 '22 17:08 arcondello

I have the wrong version number in the deprecation notice everywhere. I just wanted it to be easy to find.

arcondello avatar Nov 23 '22 18:11 arcondello

I'm a bit confused why you removed docs from greedy/neal/tabu, only to add them here (and remove submodules).

We could have done it either way. As we talked about before, the main reason was to keep the deprecation warnings easy to update and able to use the sdk version.

Regardless of the above, I think we should issue a deprecation warning on import greedy. Deprecating "on paper"/docs might not be convincing/visible enough to make users migrate.

In https://github.com/dwavesystems/dwave-ocean-sdk/issues/219 (adjusted for the version we're actually releasing on), the plan was to deprecate in docs for the remainder of Ocean 6.x. Then deprecate in code for Ocean 7, then remove in Ocean 8. This is also to give us time to update the examples etc and not get warnings.

arcondello avatar Nov 25 '22 21:11 arcondello

Add also to licenses, 2nd to last

We don't do pyqubo? And we haven't yet brought it in as a submodule so there is no file to link in the same way

arcondello avatar Nov 28 '22 22:11 arcondello