David Walend
David Walend
My kid's code, not ready to share for a while. Even in Java code the gyroscope will never read less that 0 in the current release. #693 was fixed in...
I don't think we should try for concurrency safety or state inside Sysfs. I don't think we can do it correctly and do it well at the same time; I...
For ``` public float getBatteryCurrent() { if (CURRENT_PLATFORM.equals(EV3DevPlatform.EV3BRICK)) { return Sysfs.readFloat(BATTERY_PATH + "/" + BATTERY_EV3 + "/" + CURRENT); } else { LOGGER.warn("This method is not available for {} &...
Also, most of the codebase looks like it is after the "`IOException`s are annoying" revelation. Should I follow that pattern or throw IOExcpetion s?
For Mockito - slipping an alternate filesystem in place is pretty easy. Does Mockito add value to that approach? (I think it at least adds a little.)
`Battery` doesn't seem to get any value from inheriting from `EV3DevDevice` or `Power` . Should I pull those out now, or save it for a different change? (My preference is...
Here's the PR: https://github.com/ev3dev-lang-java/ev3dev-lang-java/pull/770
Hmm. Instead of using -1f as the bad value try out Float.NaN . I think in Java Runtime Exceptions are a better answer, but at least NaN will blow up...
Here's a draft DataChannelRewriter : https://github.com/dwalend/ev3dev-lang-java/pull/1/files
Do you two think it's worth making the read() and close() methods in DataChannelRereader synchronized ? (Anything Closable has at least two states.) That'd give the thread safety. The JVM...