Results 55 comments of dvz

- [x] https://community.mybb.com/thread-240120.html (`admin/modules/forum/attachments.php`) #4790 - [x] https://community.mybb.com/thread-240207.html (`admin/modules/forum/management.php`) #4791

- [x] https://community.mybb.com/thread-240672-post-1393189.html#pid1393189 #4799 ``` Type: 2 File: member.php (Line no. 1682) Message Undefined array key "saltedpw" Back Trace: #0 errorHandler->email_error(2, Undefined array key "saltedpw", member.php, 1682) called at [/var/www/html/dv-test0/inc/class_error.php:232]...

- [x] https://community.mybb.com/thread-240796.html, https://www.mybb.de/forum/thread-39122.html #4804 ``` 1713386821 inc/class_session.php 374 2 Warning A non-numeric value encountered #0 errorHandler->error() called at [/inc/class_error.php:153] #1 errorHandler->error_callback() called at [/inc/class_session.php:374] #2 session->load_guest() called at [/inc/class_session.php:116]...

Indeed, the code at https://github.com/mybb/mybb/blob/59bce8d47cb3848d4f6be18d8114d1d298f65c88/inc/functions.php#L2708-L2710 doesn't take `false` into account (https://www.php.net/manual/en/function.sys-getloadavg.php). This results in a PHP Warning with [PHP 8.0](https://www.php.net/manual/en/migration80.incompatible.php#migration80.incompatible.core.other) (previously, a Notice - [ignored by MyBB's error handler](https://github.com/mybb/mybb/blob/f268841e760a1fc34e6e2a8b58b647079f2a1a07/inc/class_error.php#L101) -...

I want to submit PRs to replace the installer code soon, but just pushed a fix in case it causes errors in the meantime (https://github.com/mybb/mybb/commit/9d3711039c2738d8d3d18108be09de575b2a4d0b).

https://github.com/mybb/mybb/pull/4640 changes the related settings to `support_link` & `support_name`

Looks like `replyto` is incorrectly set to `0` in `Moderation::merge_threads()` and `Moderation::split_posts()`. Otherwise, it's corrected in `PostDataHandler`: https://github.com/mybb/mybb/blob/d1b1d45994e5b190e49973b8d658a89bc4e6fd3f/inc/datahandlers/post.php#L628-L639

https://community.mybb.com/thread-239484-post-1392814.html#pid1392814 ``` Warning [2] Undefined property: MyLanguage::$task_versioncheck_ran_errors - Line: 26 - File: inc/tasks/versioncheck.php PHP 8.2.12 (Linux) ```

Does the same happen for other themes, or MyBB installations? Can you attach the theme package here?