go-fuzz icon indicating copy to clipboard operation
go-fuzz copied to clipboard

go-fuzz-build: cannot find package "go-fuzz-dep" #320

Open hidu opened this issue 4 years ago • 4 comments
trafficstars

hidu avatar May 08 '21 09:05 hidu

@dvyukov @josharian can this be merged? it makes go-fuzz/go-fuzz-build compilation succeed on latest Go versions or/and in IDEs like Goland.

disconnect3d avatar Dec 23 '21 14:12 disconnect3d

@thepudds what do you think?

josharian avatar Dec 23 '21 15:12 josharian

Hi @hidu, thanks for sending this PR.

I'm not sure if it is the right fix though? I suspect it might workaround the immediate error you were seeing, but I wonder if this fix masks that the wrong GOROOT is still being used. I suspect with this fix, it is not instrumenting the standard library properly, but to be honest, I haven't looked at the suggested change closely enough, so that worry might be off base.

Stepping back, though, I wonder if there is a simpler solution that might work for you. See my comment here on the related issue.

thepudds avatar Dec 26 '21 13:12 thepudds

Hi @disconnect3d, when you say this PR is needed to work with "latest Go versions or/and in IDEs like Goland", are you referring to whether or not go-fuzz is a module itself?

If so, one approach is to work in GOPATH mode if hacking on go-fuzz itself. See some related comments in #332.

If you are not referring to issues arising from whether or not go-fuzz is a module itself, can you expand a bit more on what issues you are seeing? Does it seem to be the same problem described by @hidu in #320?

FWIW, go-fuzz works reasonably well for me with latest Go versions. I don't use Goland, though.

thepudds avatar Dec 26 '21 13:12 thepudds