David Anderson comments

Results 184 comments of


                                            David Anderson

Make InstallBuiltinNatives() virtual.

I don't think this does anything? It's not in `IPluginRuntime`, and nothing inherits from `PluginRuntime`.

Rule on function prototypes mixed for any/int and ref/non-ref variables

``` SourcePawn Compiler 1.11 Copyright (c) 1997-2006 ITB CompuPhase Copyright (c) 2004-2021 AlliedModders LLC test.sp(22) : error 100: function prototypes do not match test.sp(25) : error 100: function prototypes do...

Rule on function prototypes mixed for any/int and ref/non-ref variables

Thanks, my eyes glazed over on the first look. I've fixed the lack of errors which was definitely a serious bug. Re: any& coercing to int&... I'm on the fence....

Rule on function prototypes mixed for any/int and ref/non-ref variables

Allowing this coercion affected 0 plugins in the corpus...

Rule on function prototypes mixed for any/int and ref/non-ref variables

Do you have a testcase for non-ref coercing that doesn't work?

Compiler error 035

hrm... seems like working as-is? const is transitive, and you're discarding const by passing to Foo().

Compiler error 035

Is CheatCommand a SourceMod function? If so, let's move this bug there and fix it there.

Compiler error 035

Hate is a strong word, and thus, the _perfect_ word to describe my feelings toward "const". If I had a do-over I'd have removed it from SourcePawn on day 1....

Fix for #976 to Ignore Unused Stock Variables

This error is intentional. The warning should only elide on includes.

Fix for #976 to Ignore Unused Stock Variables

I'll fix up and land this.