Eldad Bercovici

Results 35 comments of Eldad Bercovici

@ffxsam, yeah, makes sense. I hope I manage to find some time improving this, not sure where the bottleneck is, but I'm thinking maybe if we cache multiple representations of...

Hey @ffxsam, did you manage to find the source for this? Happens to me on Chrome as well.

@ffxsam, I think I found it, changing [this block](https://github.com/bbc/peaks.js/blob/master/src/waveform-shape.js#L102-L110) to: ```js this._drawWaveform( context, this._view.getWaveformData(), Math.round(frameOffset), Math.round(this._segment ? this._view.timeToPixels(this._segment.startTime) : frameOffset), Math.floor(this._segment ? this._view.timeToPixels(this._segment.endTime) : frameOffset + width), width, height );...

When playing around with the zoom factor, `frameOffset` would sometimes be n+0.5 (148.5, for example) 🤷‍♂️

I think it happens when rendering peaks in a 4K or Retina displays. It might be that in such setup, dots cover 4 (or more) pixels, 2 per each axis,...

I agree. I'll add that while typing should invoke search, hitting the up/down arrows should still navigate the menu. Great idea, anyways!

Hey @markerikson, we have a use case for this: entities are "Segments" of shape `{ startTime: number; endTime: number }` that need to be stored sorted by both `startTime` and...

Got it. Thanks for the quick response!

A pretty common way to handle this is to display a Shortcuts modal when the user hits the question mark sign on their keyboard. But this modal will be pretty...

Great. I'm going to make some small changes. Turns out hitting Escape brings up the Console, and it's not avoidable. So Escape to bring the focus back to the sidebar...