William Dutton

Results 94 comments of William Dutton

I have been given access to pypi for this module, I'll try put out a release in the coming weeks, looking at cicd GitHub action for doing it automatically.

@ThrawnCA this can be closed when https://github.com/ckan/ckanext-xloader/commit/e6687a280aafc3c2fdba367fa04c290df3ac04dd is include in ckan/ckanext-xloader.

Hi @JVickery-TBS , What is the business use case for this change or what use behaviour are you seeing that you are trying to correct? should/could this be controlled by...

> @duttonw we have some users with large CSVs that have just spaces in empty cells instead of actual empty cells (apparently from some old data building applications). So they...

Thankfully I've not run into this before but did run into something similar when requested to review why only 3800ish rows were imported into the db instead of the 3million...

We could take it as is. I just want to not have side effects that people were using before or have the ability to not strip by flag. Reference Comic:...

> Note that the new IDataDictionaryForm allows users to customize their data dictionaries with private data that may not be appropriate for a public schema in the resource. So for...

> When re-xloader-ing data if we use `datastore_records_delete` instead of `datastore_delete` (or `datastore_delete` with an empty filters dict) then the existing columns and data dictionary values won't be removed. Then...

cicd testing issue due to missing dependancy wiring that exists in normal runtime. ``` File "/usr/lib/python3.10/site-packages/pkg_resources/__init__.py", line 2470, in resolve module = __import__(self.module_name, fromlist=['__name__'], level=0) File "/__w/ckanext-xloader/ckanext-xloader/ckanext/xloader/plugin.py", line 7, in...

Hi @JVickery-TBS , Once you can resolve the merge conflict as well as why the tests is failing, this should be good to go ``` 2024-05-14 17:22:31,450 INFO [ckan.config.environment] Loading...