BehatHtmlFormatterPlugin icon indicating copy to clipboard operation
BehatHtmlFormatterPlugin copied to clipboard

Screenshot is not attached when testing outline scenarios.

Open ceniy opened this issue 4 years ago • 8 comments

  1. When outline scenarios are executed, the ScenarioTested::BEFORE and ScenarioTested::AFTER are not triggered. So I added ExampleTested::BEFORE and ExampleTested::AFTER in the event list.
  2. Removed the codes in onAfterOutlineTested as the count will be added inside onAfterScenarioTested

ceniy avatar Feb 24 '21 09:02 ceniy

Looks good for me but we should wait some time.

PurHur avatar Feb 24 '21 10:02 PurHur

I checked the constants. Looks good but i cant test it now. Do you think this will break anything? If not i will merge it.

PurHur avatar Feb 24 '21 14:02 PurHur

I tested in my local with outline scenarios and normal scenarios. They work fine. The count of the passed and failed scenarios are correct. Furthermore screenshots are attached in the correct place.

ceniy avatar Feb 24 '21 14:02 ceniy

Then thank you for your contribution. Everything helps :)

PurHur avatar Feb 24 '21 14:02 PurHur

Hmm i will look into it. But i have to setup my pipeline again. If anybody is intrested in something automated go for it.

PurHur avatar Feb 24 '21 14:02 PurHur

So what is the state of this PR?

kalkin avatar Jul 19 '21 09:07 kalkin

@kalkin I think this PR will break stuff. Are you interested in working on the project? We actually need a github action pipeline to test this package itself. Quiet an interesting project.

PurHur avatar Nov 03 '21 15:11 PurHur

@kalkin is this PR still important to you?

I will be more active in the next time and i will check your PR as well again if it breaks stuff or not else i will merge all the things to the current master

PurHur avatar Dec 12 '23 14:12 PurHur