transfer.sh icon indicating copy to clipboard operation
transfer.sh copied to clipboard

Download button fails for names with hash mark (#)

Open Ulysses1337 opened this issue 2 years ago • 2 comments

Mirror of #213 on the web frontend. If I upload foo#1.txt with curl, the download button gives a 404 because the get link has an unencoded #, so the server will not find /get/hash/foo.

If I upload the same file with the frontend, the download button works, but the filename is truncated at the #.

Ulysses1337 avatar Oct 12 '23 21:10 Ulysses1337

@Ulysses1337

thanks for reporting the issue, I was able to reproduce

as you mentionedm for the curl upload with frontend giving 404 the problem is that the file is uploaded as foo%231.txt while the link points to foo#1.txt. I will look into urlencoding the filename in the frontend link. minor thing is that will produce urlencoded url probably for every non-ascii chars, including non latin alphabets

I will look into the js for the part on the frontend truncating at #

paolafrancesca avatar Oct 14 '23 04:10 paolafrancesca

adding that deleting from frontend is broken as well

paolafrancesca avatar Oct 14 '23 04:10 paolafrancesca