Dusty Mabe

Results 645 comments of Dusty Mabe

> @jlebon @dustymabe need your takes on this. > > * Can we extend the GC to pruning the whole `builds`, since the code for it is merged. If so,...

IOW I would limit any changes in this PR to bodhi updates (and also consult the builds in that stream to make sure the times that we set here will...

I fail to see how the `ext.config.firewall.iptables-legacy` test passes with the introduction of this code. Most likely a race condition?

> > I fail to see how the `ext.config.firewall.iptables-legacy` test passes with the introduction of this code. Most likely a race condition? > > Indeed this is weird. We should...

> > considering this comment from the description of [coreos/fedora-coreos-tracker#1818](https://github.com/coreos/fedora-coreos-tracker/issues/1818) > > > As this could potentially be a breaking change, we might want to do it only starting with...

> If we delay to F43 then we should merge #3573 in this one as well and remove the legacy test. This sounds good to me! @PeaceRebel are you comfortable...

Let's squash the last two commits together. Also there is some [post script](https://github.com/coreos/fedora-coreos-config/blob/e44375b071707719c7b4e1e4ff035f454f59f912/manifests/fedora-coreos-base.yaml#L74-L86) we should clean up. Let's just leave the changes all in fedora-coreos-base and add a new conditional_include...

> > Let's just leave the changes all in fedora-coreos-base and add a new conditional_include in there? > > Including the alternates overlay changes too? @dustymabe No sorry.. Just the...

This LGTM, but now the alternatives test (that we are also adding in this PR) can't do the full test because there is no iptables-legacy to set it back to...

> One question, how is the naming scheme of the patch files, since normally i would expect the numbers to show the order they need to be applied in and...