jetson-utils icon indicating copy to clipboard operation
jetson-utils copied to clipboard

gstEncoder::Render returns true in case of "pipeline full, skipping frame". Should it return false instead?

Open slovak194 opened this issue 2 years ago • 5 comments

Hi! I'm not sure if this is a bug or intended behavior. My initial expectation was to receive false in case of "full pipeline" to be able to give it another try.

https://github.com/dusty-nv/jetson-utils/blob/56d57f6713a5afe9029ab768ec5d13c285a52dfb/codec/gstEncoder.cpp#L435-L440

Here is what VideoOutput interface says:

https://github.com/dusty-nv/jetson-utils/blob/56d57f6713a5afe9029ab768ec5d13c285a52dfb/video/videoOutput.h#L166-L168

It is not clear if this is an error or warning situation. If it is still a warning, then an additional method shall be added to check if VideoOutput is ready to receive the next frame. Otherwise, I'd return false in this case.

Best regards, Alex

slovak194 avatar Jun 30 '22 06:06 slovak194

Hi, can you solve this problem? I encountered this error in x86 with input=video and output=rtp.

JackeyGuo avatar Sep 26 '22 08:09 JackeyGuo

Hi, @JackeyGuo. I've just changed true to false in the place I mentioned in my initial post. This solved the issue and I can retry pushing to the pipeline later if it is already full.

slovak194 avatar Sep 27 '22 12:09 slovak194

@slovak194 This is not your initial post? can you elaborate on which parameter's TRUE is changed to FALSE.

JackeyGuo avatar Sep 28 '22 05:09 JackeyGuo

@slovak194 This is not your initial post? can you elaborate on which parameter's TRUE is changed to FALSE.

https://github.com/dusty-nv/jetson-utils/commit/ea3c56b315d162202e1f05c1963b7e2edcdb7629

slovak194 avatar Nov 21 '22 08:11 slovak194

Thank you for your reply.

JackeyGuo avatar Nov 21 '22 09:11 JackeyGuo