dustinxie

Results 21 comments of dustinxie

@ligi could you check the PR again? https://nightly.iotexscan.io/ is working now, thx

@ligi could you check the PR again? https://nightly.iotexscan.io/ is working now, thx

@ligi could you check the PR again? https://nightly.iotexscan.io/ is working now, thx

close this since no satisfactory explanation is given

it is /action/protocol/staking/handlers_test.go

Self-stake purpose is (like you mentioned) "need a primary responder (e.g., slashing for doing bad things)", if we use a different address, it is still "self-stake" but to a different...

> From my understand, the idea of pr is to build a mapping for deduplicated data. Changing the implementation of KVStore is more reasonable than changing boltdb itself, where does...

@millken can you update the PR per our latest conversation?

> What is the purpose of deleting the interface in the pr? This issue has been discussed before at #2647 oh, #2647 already discussed this. The purpose is that `DeleteTipBlock()`...

checked again, tests are failing in these 3 files due to proto change: 1. indexprotocol/blocks/protocol_test.go 2. indexprotocol/votings/protocol_test.go 3. indexprotocol/votings/stakingprotocol_test.go for all other t.Skip(), can simply revert them, tests can pass