Dustin Moris Gorski comments

Results 90 comments of


                                            Dustin Moris Gorski

Capitalized handlers ignore custom serializers

Looking into this it seems that both are using the registered `IJsonSerializer` but `Successful.OK` uses [Content Negotiation](https://github.com/giraffe-fsharp/Giraffe/blob/master/DOCUMENTATION.md#content-negotiation) and therefore might attempt to serialize the response in a different content type...

We should allow for custom model binding of properties

> Also I was unable to map to the boolean. In addition, html checkboxes don't submit anything if they're not checked, so by default/definition you'll never get the 'false' side...

QUESTION: Additional configuration parameters with functional startup

Sorry could you clarify what exactly you would like to do? [Dependencies are managed the ASP.NET Core way](https://github.com/giraffe-fsharp/Giraffe/blob/master/DOCUMENTATION.md#dependency-management) and you can retrieve a dependency from ASP.NET Core's DI container using...

Server-Sent Events in Giraffe

Nothing in Giraffe for SSE yet. I always felt that things like SSE deserve a new middleware which can handle `text/event-stream` requests and then register some handlers/publishers to those open...

Question: How Swagger support is expected to eventually work

> Do we want to make a change now to the Endpoint type to avoid a breaking change Yes > Do we want to build out the OpenAPI gen ourselves?...

[Question] Multipart file upload without writing to disc?

Have you had a look at the [official ASP.NET Core documentation for file uploads](https://docs.microsoft.com/en-us/aspnet/core/mvc/models/file-uploads?view=aspnetcore-5.0)? There is an entire section describing [how to stream a large file upload](https://docs.microsoft.com/en-us/aspnet/core/mvc/models/file-uploads?view=aspnetcore-5.0#upload-large-files-with-streaming). It uses MVC...

Dustin Moris Gorski