FXTrayIcon icon indicating copy to clipboard operation
FXTrayIcon copied to clipboard

Support for RadioMenuItems

Open azplanlos opened this issue 3 years ago • 6 comments

It would be very nice to have support for CheckMenuItem and RadioMenuItem to allow users to toggle select in the tray icon menu.

azplanlos avatar May 09 '22 16:05 azplanlos

@azplanlos - This is an interesting suggestion ... however, this won't work, and here is why...

JavaFX MenuItems are CONVERTED over to an AWT framework before they are added to the FXTrayIcon popup menu. And since they technically are not rendered as JavaFX objects, there is no hope of implementing a full-flavored JavaFX object within FXTray Icon.

Maybe one day, JavaFX will actually support the System Tray, but until that day comes, this is the best we got.

EasyG0ing1 avatar May 11 '22 14:05 EasyG0ing1

I implemented a version supporting CheckMenuItems and will create a pull request shortly.


Von: Michael Sims @.> Gesendet: Wednesday, May 11, 2022 4:01:17 PM An: dustinkredmond/FXTrayIcon @.> Cc: Andreas Zöllner @.>; Mention @.> Betreff: Re: [dustinkredmond/FXTrayIcon] Support for RadioMenuItems (Issue #51)

@azplanloshttps://github.com/azplanlos - This is an interesting suggestion ... however, this won't work, and here is why...

JavaFX MenuItems are CONVERTED over to an AWT framework before they are added to the FXTrayIcon popup menu. And since they technically are not rendered as JavaFX objects, there is no hope of implementing a full-flavored JavaFX object within FXTray Icon.

Maybe one day, JavaFX will actually support the System Tray, but until that day comes, this is the best we got.

— Reply to this email directly, view it on GitHubhttps://github.com/dustinkredmond/FXTrayIcon/issues/51#issuecomment-1123802516, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AARE55UFMXDB4P5Z7WG5R3TVJO4S3ANCNFSM5VO2W24Q. You are receiving this because you were mentioned.Message ID: @.***>

azplanlos avatar May 11 '22 14:05 azplanlos

@azplanlos - can't wait to see how you did it ... my experience with AWT is about on par with my lifetime skydiving hours ... which equates to about 20 minutes ... ☺

EasyG0ing1 avatar May 11 '22 14:05 EasyG0ing1

@azplanlos , I'm with @EasyG0ing1, I'm fairly versed with JavaFX, but my prior experience with AWT going into the development of this library leaves much to be desired. I look forward to your pull request, and am eager to see your new development. Thank you tons for your contribution!

dustinkredmond avatar May 12 '22 00:05 dustinkredmond

@azplanlos

I implemented a version supporting CheckMenuItems and will create a pull request shortly.

How is that PR coming along?

EasyG0ing1 avatar Jun 11 '22 16:06 EasyG0ing1

Sorry, I have been busy with some other stuff. PR is on it's way.

azplanlos avatar Jun 14 '22 07:06 azplanlos

Thanks all for the efforts to support CheckMenuItems, this looks great! Closing this issue for now since changes were merged to main.

dustinkredmond avatar Oct 10 '22 20:10 dustinkredmond