hollywood
hollywood copied to clipboard
dustinkirkland
snap: adjustments for hollywood
- Use base: core18
- Move to strict confinement
- Patch agp to be snap-aware
- Patch 3 hollywood files to be snap-aware:
- /dev/shm path
- man related path
- paths for hexdump
- Add command-chain for minor workarounds:
- BYOBU_PREFIX uses realpath in .byoburc
- Link czze plugins to the confined home
Signed-off-by: Sergio Schvezov [email protected]
I would personally merge hollywood and wallstreet into one snap and have the Snap Store create an alias for wallstreet (to no have to call hollywood.wallstreet) and have just 1 snap directory.
Regardless, I would git mv snap.hollywood snap and hook up with https://build.snapcaft.io for automatic builds.
To build you will need the latest snapcraft from the stable channel from https://snapcraft.io/snapcraft and to make use of lxd you can call it like snapcraft --use-lxd.
I have done light verification that confinement should be good here and I do not think going back to classic confinement would be required, but keep in mind that auto-refreshes from a confined snap to a classic one is a manual process.
TODO (if ok with):
- use this here source instead of the hollywood
stage-packagesentry. - add support for an alternate sysroot for lib/hollywood and remove these here patches.
Build is failing (both with lxd and without) with:
... Fetched 20.2 MB in 5s (4197 kB/s) Reading package lists... Done Building dependency tree Reading state information... Done 18 packages can be upgraded. Run 'apt list --upgradable' to see them. Failed to pull source: unable to determine source type of 'snap/local'.
Check that the URL is correct or consider specifying source-type for this
part. See snapcraft help sources for more information.
Run the same command again with --debug to shell into the environment if
you wish to introspect this failure.
On Sun, Feb 16, 2020 at 12:00 PM Sergio Schvezov [email protected] wrote:
- Use base: core18
- Move to strict confinement
- Patch agp to be snap-aware
- Patch 3 hollywood files to be snap-aware:
- /dev/shm path
- man related path
- paths for hexdump
- Add command-chain for minor workarounds:
- BYOBU_PREFIX uses realpath in .byoburc
- Link czze plugins to the confined home
Signed-off-by: Sergio Schvezov [email protected]
I would personally merge hollywood and wallstreet into one snap and have the Snap Store create an alias for wallstreet (to no have to call hollywood.wallstreet) and have just 1 snap directory. Regardless, I would git mv snap.hollywood snap and hook up with https://build.snapcaft.io for automatic builds.
To build you will need the latest snapcraft from the stable channel from https://snapcraft.io/snapcraft and to make use of lxd you can call it like snapcraft --use-lxd.
TODO (if ok with):
- use this here source instead of the hollywood stage-packages entry.
- add support for an alternate sysroot for lib/hollywood and remove these here patches.
You can view, comment on, or merge this pull request online at:
https://github.com/dustinkirkland/hollywood/pull/37 Commit Summary
- snap: adjustments for hollywood
File Changes
- A snap.hollywood/local/0001-apg.patch https://github.com/dustinkirkland/hollywood/pull/37/files#diff-0 (20)
- A snap.hollywood/local/0002-byobu-shm.patch https://github.com/dustinkirkland/hollywood/pull/37/files#diff-1 (20)
- A snap.hollywood/local/0003-hexdump.patch https://github.com/dustinkirkland/hollywood/pull/37/files#diff-2 (13)
- A snap.hollywood/local/0004-man.patch https://github.com/dustinkirkland/hollywood/pull/37/files#diff-3 (11)
- A snap.hollywood/local/setup https://github.com/dustinkirkland/hollywood/pull/37/files#diff-4 (22)
- M snap.hollywood/snapcraft.yaml https://github.com/dustinkirkland/hollywood/pull/37/files#diff-5 (53)
Patch Links:
- https://github.com/dustinkirkland/hollywood/pull/37.patch
- https://github.com/dustinkirkland/hollywood/pull/37.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/dustinkirkland/hollywood/pull/37?email_source=notifications&email_token=AAGMZBRAA6S2IOHXGLI3AXLRDF5KZA5CNFSM4KWFJJC2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IN3TT7A, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGMZBU5QOIETZ5ABMLJ3UDRDF5KZANCNFSM4KWFJJCQ .
Did you mv hollywood.snap snap before building and run from SOURCE_ROOT?
No, but I changed "Source: snap/local" to "Source: ./local", and that built successfully.
Let me try it your way, too...
@DustinKirkland
On Mon, Feb 17, 2020 at 8:58 AM Sergio Schvezov [email protected] wrote:
Did you mv hollywood.snap snap before building and run from SOURCE_ROOT?
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/dustinkirkland/hollywood/pull/37?email_source=notifications&email_token=AAGMZBR6CE2I2DZNCA2IXPTRDKQYFA5CNFSM4KWFJJC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL6WSBA#issuecomment-587032836, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGMZBXFBM4GBBRQ5F74Y2DRDKQYFANCNFSM4KWFJJCQ .
Are we moving forward with this? Would you like for me to work on what is on that TODO?
Hey Sergio,
A belated thanks! Sorry it's taken me a while to get back to this (it's kind of just a hobby, these days, you know).
I've just committed and pushed the changes you've made and released hollywood 1.21. It appears to me to build and publish the snap successfully now... It would be great if someone else could confirm.
I'd be happy for you to send a patch to combine wallstreet and hollywood into a single hollywood snap. And I'm happy to take a patch for the other two TODOs too.
Thanks, Sergio! You're the best, pal ;-)
@DustinKirkland
On Thu, Feb 27, 2020 at 11:14 AM Sergio Schvezov [email protected] wrote:
Are we moving forward with this? Would you like for me to work on what is on that TODO?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dustinkirkland/hollywood/pull/37?email_source=notifications&email_token=AAGMZBWKHMH3F7T7RJRYWALRE7YGZA5CNFSM4KWFJJC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENFFLCI#issuecomment-592074121, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGMZBR4C3JPBHO2ZU2CD6DRE7YGZANCNFSM4KWFJJCQ .