golang-petname icon indicating copy to clipboard operation
golang-petname copied to clipboard

added support for multiple dictionaries

Open zippoxer opened this issue 5 years ago • 1 comments

Hi,

Following your comment on Reddit, this is my attempt at making a pull request with the changes I've made at zippoxer/petname.

This pull request adds support for multiple dictionaries by introducing the Dict interface, which is implemented by packages under the dict folder.

The usage of the Generate method has also changed, and it now takes a Dict as it's first argument:

petname.Generate(dict.Small, 2, "-")

I should note that this pull request might break some of the scripts under the debian folder, since I didn't yet take a close look in there.

I'm taking the old repository (zippoxer/petname) down, as this fork provides the same functionality. I hope this would make things right between us.

Cheers :-)

zippoxer avatar Apr 25 '19 14:04 zippoxer

Cool, thanks for submitting this. I'm still reviewing it. I see that, basically, you want the same support in the golang-petname package, for small/medium/large wordlists, that we already have in the master "petname" shell implementation. I'm working on merging your pull request. Thanks.

dustinkirkland avatar Jun 13 '19 19:06 dustinkirkland