homebridge-rinnai-controlr icon indicating copy to clipboard operation
homebridge-rinnai-controlr copied to clipboard

Change “Heating to” to “Heat to”

Open Bleh55 opened this issue 3 years ago • 4 comments

The icon in Home.app says “Heating to xxx” and always throws me off thinking it is actively heating. Does it make sense to change that to “Heat to xxx”? That also matches the way thermostats display when it is not actively heating.

Bleh55 avatar Dec 11 '21 23:12 Bleh55

Yeah, unfortunately, this is HomeKit's thermostat behavior, and there's nothing that can be done either in this plugin or in Homebridge.

dustindclark avatar Dec 12 '21 16:12 dustindclark

Reopening..looks like the Nest plugin handles this better. Will see if I can follow that pattern.

dustindclark avatar Dec 12 '21 20:12 dustindclark

If you want it to look "idle" (thus say "Heat to..." instead of "Heating to...", and will be a green icon instead of orange), this

bindStaticValues() {
        this.service.updateCharacteristic(this.platform.Characteristic.TemperatureDisplayUnits, this.platform.getConfig().temperatureUnits === constants_1.TemperatureUnits.F
            ? this.platform.Characteristic.TemperatureDisplayUnits.FAHRENHEIT
            : this.platform.Characteristic.TemperatureDisplayUnits.CELSIUS);
        this.service.updateCharacteristic(this.platform.Characteristic.CurrentHeatingCoolingState, this.platform.Characteristic.CurrentHeatingCoolingState.HEAT);
    }

can be changed to this:

bindStaticValues() {
        this.service.updateCharacteristic(this.platform.Characteristic.TemperatureDisplayUnits, this.platform.getConfig().temperatureUnits === constants_1.TemperatureUnits.F
            ? this.platform.Characteristic.TemperatureDisplayUnits.FAHRENHEIT
            : this.platform.Characteristic.TemperatureDisplayUnits.CELSIUS);
        this.service.updateCharacteristic(this.platform.Characteristic.CurrentHeatingCoolingState, this.platform.Characteristic.CurrentHeatingCoolingState.OFF);
    }

https://github.com/dustindclark/homebridge-rinnai-controlr/blob/bd3a4c3f1c4b97a4ecb8098317e2ad12f412f135/src/platformAccessory.ts#L115-L122

tedinorbit avatar May 24 '22 19:05 tedinorbit