Championify icon indicating copy to clipboard operation
Championify copied to clipboard

Auto Update item sets

Open dustinblackman opened this issue 9 years ago • 17 comments

Overview

Have Championify run in the background with a tray icon, as well as a view to notify of when the last update happened. The import button would more or less need to be converted to save button to prevent users from running an import just to save preferences.

dustinblackman avatar Jul 20 '15 17:07 dustinblackman

Would this be something that runs at login in the background, or something on a fixed schedule? Maybe have a process that detects when you launch League and updates then, though that sounds hard to properly implement.

nilesr avatar Jul 20 '15 18:07 nilesr

Technically, both. Auto update on run, and then continue to update on a fixed schedule. It'll be up to the user to decide whether they want it to run on boot or not. Electron I believe has a tray feature for Windows/OSX, I'd start somewhere there when I get around to it. :)

dustinblackman avatar Jul 20 '15 18:07 dustinblackman

https://github.com/atom/electron/blob/master/docs/api/tray.md API Doc about the tray feature thing.

josevill avatar Sep 18 '15 22:09 josevill

@dustinblackman any update on this? This would be a really nice feature, even to have run once a week.

ilanbiala avatar Jul 26 '16 15:07 ilanbiala

It's pushed near the bottom of the backlog at the moment. My development time has been rather limited lately. Contributors are welcome.

dustinblackman avatar Jul 27 '16 04:07 dustinblackman

@dustinblackman I'm a developer familiar with Electron (but not worked with it yet)--interested in a hand? I'm not sure that Electron permits background services natively so this may portion have to be written in something else. Thanks for a great app! 👍

colbin8r avatar Jan 15 '17 08:01 colbin8r

Sure I'd love some help! Electron can for sure do background process', you can control when the window is shown and when it's not. The idea would be to have it running without a visible window, but in the tray instead, and a scheduled task to pull in sources.

dustinblackman avatar Jan 15 '17 16:01 dustinblackman

Could you also use Task Scheduler (or something of the sort) to run championify.exe --autorun on a schedule?

iggyvolz avatar Jan 15 '17 22:01 iggyvolz

@iggyvolz It could be setup as a .BAT file that runs a command to schedule such task in case you're running Windows, I don't know how it'd be using OSX.

Windows Task scheduler: schtasks /create /sc DAILY /tn "Update Championify Lists" /tr "dir-to-championify-binaries" /st 10:00

josevill avatar Jan 15 '17 22:01 josevill

The idea is to have it built in rather then a separate scheduler.

dustinblackman avatar Jan 16 '17 00:01 dustinblackman

@dustinblackman Could you link to the Electron docs that allow headless running of the app? The only ideas I could find were this: https://discuss.atom.io/t/headless-electron/20173/3

colbin8r avatar Jan 17 '17 22:01 colbin8r

Also: https://discuss.atom.io/t/windows-background-service/20777/6

colbin8r avatar Jan 17 '17 22:01 colbin8r

Please make sure that this is opt-in. I'm not a fan of applications that decide to run on startup without my permission.

Nefari0uss avatar Jan 18 '17 01:01 Nefari0uss

@dustinblackman I've forked your repo and started working on it. I'm certainly not as familiar with Electron as I thought, though! 😛

colbin8r avatar Jan 28 '17 21:01 colbin8r

This feature also should be able to detect if LoL is opened or not, and only update item sets if LoL is not running. I don't know what happens if Championify tries to update itemsets while running the clients or the game.

cafeina-software avatar Jan 30 '17 14:01 cafeina-software

@fuckyourselfup Nothing. The updates item sets just won't be seen in game until the next match.

dustinblackman avatar Jan 30 '17 16:01 dustinblackman

At minimum, I'd use the batch job feature. I'd set it up with the Windows task scheduler or cron/launchd on macOS. I'm not great at the code section, but I'm willing to beta test it

computergeek125 avatar Mar 17 '18 17:03 computergeek125