hlsinjector icon indicating copy to clipboard operation
hlsinjector copied to clipboard

Fails without errors after upgrading from PHP 7.3 to PHP 8.2

Open JungleGenius opened this issue 1 year ago • 1 comments

First thank you for posting this with the generous licensing terms. That said I just recently updated to PHP 8.2 and it quit working, but does not throw any errors either. Normally the exec_output array looks like this:

( 
    [0] => ** Imported 1 metadata tags
    [1] => Parsed 1551 MPEG TS frames with 0 errors
    [2] => Total of 1 programs and 2 streams
    [3] => Injected 0 frames
    [4] => Finished in 4.734ms
)

But now it only outputs:

( 
    [0] => ** Imported 1 metadata tags
)

I'll be happy to offer a modest bounty to get this working again under PHP 8.2. There is so much low level bit twiddling going on in the code I don't feel like doing this myself unless I absolutely have too. If it comes to that I will make a pull request.

Thanks.

JungleGenius avatar Aug 21 '23 14:08 JungleGenius

Update: Turns out the changes in this old un-merged pull request fixes the issues on PHP 8.2 https://github.com/dusterio/hlsinjector/pull/6

JungleGenius avatar Aug 24 '23 13:08 JungleGenius