wallet-cli icon indicating copy to clipboard operation
wallet-cli copied to clipboard

Prover and State server should have the capability to have different ipc method

Open ZER0 opened this issue 2 years ago • 2 comments

Describe what you want implemented prover and state server should have the capability to have different ipc method.

Describe "Why" this is needed It's possible that users decide to install a local state server (rusk) but not having the machine powerful enough to compute a prove. So the state server should use uds, where the prover should use tcp. Currently the method has to be the same for both.

Describe alternatives you've considered As workaround, the user can use tcp also locally.

Additional context This requires a fundamental shift in how the wallet library is designed. So it's not something we want to do for the time being (as said, a workaround it's possible), but I'm still open the issue to keep this in the back of our heads.

ZER0 avatar Aug 24 '22 11:08 ZER0

In addition to what already said, I believe we should remove the ipc_method argument and start to derive it from the url itself

let url = Url::parse("http://mydomain:8585").unwrap();
let url = Url::parse("unix:/run/foo.socket").unwrap();
match url.scheme() {
    "http"|"https" => println!("Connecting to {}", url.as_str()),
    "unix"=>println!("Connecting with UDS to {}", url.path()),
    _ => panic!("Unsupported"),
}

herr-seppia avatar Sep 09 '22 12:09 herr-seppia

We're thinking of removing the UDS method and only use TCP/IP for both local and remote nodes

Daksh14 avatar May 30 '23 14:05 Daksh14