wallet-cli icon indicating copy to clipboard operation
wallet-cli copied to clipboard

Published 20 hours ago • verified publisher icon dusk-network

Handle SIGTERM properly

Open herr-seppia opened this issue 2 years ago • 0 comments

Summary

The current implementation simply quit the program. To be more precise, some part of the code can easily handle the cancellation, but the current implementation simply catch it and shade it.

Possible solution design or implementation

Both this issue and #97 should be addressed taking in consideration the best UX possibile

Additional context

I decided to shade it, because this CTRL+C is just the display of requestty::ErrorKind::Interrupted. This means that we will have a different UX depending on when the SIGTERM is catched

I mean:

  • During a prompt wait I will get this display
  • During any other phase (eg: while I'm fetching notes) nothing display

Originally posted by @herr-seppia in https://github.com/dusk-network/wallet-cli/pull/101#discussion_r988867291

herr-seppia avatar Oct 06 '22 12:10 herr-seppia