rusk icon indicating copy to clipboard operation
rusk copied to clipboard

Update transfer events

Open Neotamandua opened this issue 5 months ago • 0 comments

Changes:

  • Use consts for event topics in transfer contract events, so that we can also use that const imported elsewhere to match on topics.
  • Renamed "from" & "to" to "sender" & "receiver" for MoonlightTransactionEvent and related logic, so that it is consistently called sender/receiver in every context.
  • Standardized the field order to sender, receiver, value in all transfer event structs.
  • Changed "CONVERT" to "convert" in the self.mint_withdrawal call as it is also lower case for "mint" & "withdraw" calls.

The new sender, receiver, value ordering of fields (as MoonlightTransactionEvent already had with from, to, value) made the most sense to me, but I have no hard opinion on it. If there is a problem with it, I can change it back.

Neotamandua avatar Sep 27 '24 18:09 Neotamandua