rusk icon indicating copy to clipboard operation
rusk copied to clipboard

Add gap options for the `Card` component

Open ascartabelli opened this issue 1 year ago • 2 comments

Summary

The Card component adds a bottom margin of .5em to its header.

Depending on where the card is used we may want different gaps.

Possible solution design or implementation

Add a gap property which can have fixed values (e.g. "small" | "normal" | "double") and style it to use the already defined gaps in CSS variables.

Additional context

We may want to update the login page when we tackle this, as its gaps are way smaller than the design on Figma.

ascartabelli avatar Dec 11 '23 13:12 ascartabelli

What should i do? i think @ascartabelli already answered.

Maybe this can be helpful?

Screenshot 2024-04-22 at 16 12 33

laremas avatar Apr 22 '24 11:04 laremas

Spoke with @laremas, will go with the following options for the time-being:

small: 8px default: 10px medium: 20px large: 30px;

We can revisit this once the updated design system is in place.

nortonandreev avatar Apr 29 '24 13:04 nortonandreev