plonk

plonk copied to clipboard

Lift the `Default` bound for the `Circuit` trait

4

The `Compiler::compile` function keeps this bound since it actually requires the circuit to have a `Default` implementation, but all other functionality now works without said bound. Resolves #715

ureeves

**Describe what you want implemented** A circuit shouldn't be required to be `Default` to satisfy the `Circuit` trait. The proposal is to remove said bound, and adjust accordingly. **Describe "Why"...

ureeves

moCello

chore: fix some typos in comments

1

hardlydearly

Make rounds match the paper

1

xevisalle

The calculation of one of the challenges is not done in the same order as specified in the [PlonK](https://eprint.iacr.org/2019/953.pdf) paper. Since there are already two articles describing attacks derived from...

marta-belles

#### Summary Atm, the documentation includes how custom gates are used at the Plonk protocol level. However, how the specific custom gates are constructed is still something TBC. We should...

xevisalle

Hello I fixed several spelling issues in your docs. Br, Elias.

nnsW3

#### Summary There are some leftovers in the code that need to be addressed, i.e. FIXMEs, TODOs, etc. In particular: - https://github.com/dusk-network/plonk/blob/499a70f5da81ade4dbd226f00413a7a17e96f857/src/composer.rs#L507 - This list in WIP

xevisalle